[Sync] 0.12.0 branch to include all commits related to Authorino #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to run ODH without Authorino when KServe is Removed. Signed-off-by: Spolti <fspolti@redhat.com>
check if the serving is enabled as service mesh is tied with Authorino. this will allow rawDeployments to also work without Authorin. Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Spolti <fspolti@redhat.com>
[RHOAIENG-4191] - odh-model-controller should tolerate missing Authorino
Signed-off-by: Manjunath Kumatagi <mkumatag@in.ibm.com>
Remove GOARCH from the go build
When a KServe InferenceService is created, odh-model-controller enrolls the ISVC namespace to the mesh, if needed. It was found that sometimes the namespace enrollment process may take a little time to be processed. Since KServe and odh-model-controllers are (to certain extent) independent of each other, sometimes KServe controller and Knative serving controller are faster and the pod from the KSVC may be created faster than the mesh enrollment process. This would lead to the KSVC pod not having an Istio sidecar. Since the Istio authorization rules are evaluated on the sidecar of target service, the missing sidecar on the model/ksvc pod would mean that the traffic would bypass the authorization rules and this impacts ODH KServe authorization (ref: https://istio.io/latest/docs/ops/best-practices/security/#server-first-tcp-protocols-are-not-supported). In an effort to prevent that situation, this is adding a new validating webhook that would block creation of the Knative Service until the namespace is acknowledged to be a member of the service mesh. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Prevent creation of KSVC if its namespace is not in the Mesh
Latest one requires go1.22 which is not the version used by prow jobs atm. Signed-off-by: bartoszmajsak <bartosz.majsak@gmail.com>
fix(test): pins k8s env test to concrete version
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jooho
changed the title
Jooho
changed the title
|
/unhold |
|
/test |
|
@Jooho: No presubmit jobs available for opendatahub-io/odh-model-controller@release-0.12.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Authorino-related commits are scattered so it is difficult to cherry-pick them to 0.11.1(release branch). so we need to promote the incubating branch to the release branch.
How Has This Been Tested?
Merge criteria: