Upgrade kserve version to v0.12.1 in odh-model-controller #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaibhavjainwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
vaibhavjainwiz
force-pushed
the
update_kserve
branch
from
bd5c6e1
to
eb466e1
Compare
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
Jooho
reviewed
May 30, 2024
|
/test unit |
|
/retest |
| @@ -26,11 +27,11 @@ func NewKsvcValidator(client client.Client) *ksvcValidator { | |||
| return &ksvcValidator{client: client} | |||
| } | |||
|
|
|||
| func (v *ksvcValidator) ValidateCreate(ctx context.Context, obj runtime.Object) error { | |||
| func (v *ksvcValidator) ValidateCreate(ctx context.Context, obj runtime.Object) (warnings admission.Warnings, err error) { | |||
There was a problem hiding this comment.
Why do you need to add an additional return object (warnings) that seems to be always null?
There was a problem hiding this comment.
its a new method signature of ValidateCreate in controller-runtime v0.16.3.
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.16.4/pkg/webhook/admission/validator.go#L42
|
/lgtm |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modelmesh-serving has already been upgraded to Kserve v0.12 but odh-model-controller is left behind. With this PR I mean to upgrade the kserve version
odh-model-controllerto v0.12.How Has This Been Tested?
Merge criteria: