Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add watch object 'configMap' for metrics dashboard configmap #243

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Jul 22, 2024

Description

#240 missed watch object configMap.

How Has This Been Tested?

(NOTE) Loopy was tested on fedora only.

Test

Env setup

  • Using source

    mkdir /tmp/test
    cd /tmp/test
    git clone git@github.com:Jooho/loopy.git
    cd loopy
    make init  
    
  • Using docker image

docker run --name loopy -it  quay.io/jooholee/loopy:latest /bin/bash

Create a cluster information script

cd loopy

cat cluster_info.sh
CLUSTER_CONSOLE_URL=https://console-openshift-console.XXXX
CLUSTER_API_URL=https://api.XXX:443
CLUSTER_ADMIN_ID=admin
CLUSTER_ADMIN_PW=password
CLUSTER_TOKEN=sha256~XXX
CLUSTER_TYPE=ROSA

Install Kserve with a new manifests

./loopy playbooks run  odh-stable-install-kserve-serverless-on-existing-cluster -p CUSTOM_KSERVE_MANIFESTS=https://github.com/jooho/kserve/tarball/master  -p CUSTOM_ODH_MODEL_CONTROLLER_MANIFESTS=https://github.com/jooho/odh-model-controller/tarball/pr-test-manifests -vvv -i ./cluster_info.sh

Deploy sample sklearn model

./loopy units run test-kserve-sklearn-v2-iris-role -vvv -i ./cluster_info.sh 

Checks

  1. Verify if configmap for metrics dashboard is created
oc get configmap sklearn-example-isvc-iris-v2-rest-metrics-dashboard -n kserve-demo

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: jooho lee <jlee@redhat.com>
@mwaykole
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, mwaykole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f26c442 into opendatahub-io:main Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants