Skip to content

Commit

Permalink
tests: fix lora tests handling
Browse files Browse the repository at this point in the history
  • Loading branch information
dtrifiro committed Jul 19, 2024
1 parent 0b69d69 commit fc014d7
Showing 1 changed file with 16 additions and 19 deletions.
35 changes: 16 additions & 19 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,50 +39,47 @@ def monkeysession():


@pytest.fixture(scope="session")
def lora_enabled():
def lora_available() -> bool:
# lora does not work on cpu
return not vllm.config.is_cpu()


@pytest.fixture(scope="session")
def requires_lora(lora_enabled): # noqa: PT004
if not lora_enabled:
pytest.skip(reason="Lora is not enabled. (disabled on cpu)")
def lora_adapter_name(request: pytest.FixtureRequest):
if not request.getfixturevalue("lora_available"):
pytest.skip("Lora is not available with this configuration")


@pytest.fixture(scope="session")
def lora_adapter_name(requires_lora):
return "lora-test"


@pytest.fixture(scope="session")
def lora_adapter_path(requires_lora):
def lora_adapter_path(request: pytest.FixtureRequest):
if not request.getfixturevalue("lora_available"):
pytest.skip("Lora is not available with this configuration")

from huggingface_hub import snapshot_download

path = snapshot_download(repo_id="yard1/llama-2-7b-sql-lora-test")
return path


@pytest.fixture(scope="session")
def args( # noqa: PLR0913
def args(
request: pytest.FixtureRequest,
monkeysession,
grpc_server_thread_port,
http_server_thread_port,
lora_enabled,
lora_adapter_name,
lora_adapter_path,
lora_available,
) -> argparse.Namespace:
"""Return parsed CLI arguments for the adapter/vLLM."""
# avoid parsing pytest arguments as vllm/vllm_tgis_adapter arguments

extra_args: list[str] = []
if lora_enabled:
extra_args.extend(
(
"--enable-lora",
f"--lora-modules={lora_adapter_name}={lora_adapter_path}",
)
)
if lora_available:
name = request.getfixturevalue("lora_adapter_name")
path = request.getfixturevalue("lora_adapter_path")

extra_args.extend(("--enable-lora", f"--lora-modules={name}={path}"))

monkeysession.setattr(
sys,
Expand Down

0 comments on commit fc014d7

Please sign in to comment.