Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject: Pin OpenTelemetry versions #106

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented Aug 21, 2024

Description

This PR pins the major and minor versions of the OpenTelemetry packages to avoid potential issues with version mismatches.
This is a follow-up to vllm-project/vllm#7266

How Has This Been Tested?

I build the project python -m build && pip install dist/*whl and manually verified that the OTel package versions fall within the pinned range by running pip list | grep opentelemetry

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.98%. Comparing base (4a053ff) to head (ab22f4b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   55.98%   55.98%           
=======================================
  Files          24       24           
  Lines        1486     1486           
  Branches      268      268           
=======================================
  Hits          832      832           
  Misses        579      579           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ronensc!

@njhill njhill added this pull request to the merge queue Aug 22, 2024
Merged via the queue into opendatahub-io:main with commit a8346c9 Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants