Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor LoRARequest based on upstream #74

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

prashantgupta24
Copy link
Contributor

Changes need to be done based on this: vllm-project/vllm#6234

ERROR 07-31 22:37:30 async_llm_engine.py:56] UnboundLocalError: cannot access local variable 'lora_path' where it is not associated with a value
Exception in callback _log_task_completion(error_callback=<bound method...7f8825413c10>>)(<Task finishe...ith a value")>) at /home/develop/.conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py:36
handle: <Handle _log_task_completion(error_callback=<bound method...7f8825413c10>>)(<Task finishe...ith a value")>) at /home/develop/.conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py:36>
Traceback (most recent call last):
  File "/home/develop/.conda/envs/vllm/lib/python3.11/site-packages/vllm/lora/worker_manager.py", line 93, in _load_adapter
    lora_path = get_adapter_absolute_path(lora_request.lora_path)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/develop/.conda/envs/vllm/lib/python3.11/site-packages/vllm/lora/utils.py", line 136, in get_adapter_absolute_path
    if lora_path.startswith('~'):
       ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'PosixPath' object has no attribute 'startswith'

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.29%. Comparing base (47869cc) to head (efa37f9).
Report is 6 commits behind head on main.

Files Patch % Lines
src/vllm_tgis_adapter/grpc/adapters.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files          20       20           
  Lines        1186     1186           
  Branches      210      210           
=======================================
  Hits          727      727           
  Misses        383      383           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro dtrifiro force-pushed the fix-lora-request-params branch from b71f2f6 to d81e773 Compare August 7, 2024 15:25
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@dtrifiro dtrifiro force-pushed the fix-lora-request-params branch from d81e773 to efa37f9 Compare August 7, 2024 15:32
@dtrifiro dtrifiro enabled auto-merge August 7, 2024 15:32
@dtrifiro dtrifiro added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 9cab31d Aug 7, 2024
3 checks passed
@dtrifiro dtrifiro deleted the fix-lora-request-params branch August 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants