Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ubi base image tag #24

Merged

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented May 15, 2024

Dockerfile.ubi: use 9.4 as base UBI tag

@dtrifiro dtrifiro changed the base branch from main to ibm_main May 15, 2024 15:00
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@z103cb
Copy link

z103cb commented May 15, 2024

@dtrifiro I have rebased this branch.

@z103cb
Copy link

z103cb commented May 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 15, 2024
@z103cb
Copy link

z103cb commented May 15, 2024

/approve

Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 059b81b into opendatahub-io:ibm_main May 15, 2024
3 checks passed
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 16, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This
PR makes the mypy suggested modifications to our code.

---------

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 16, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This
PR makes the mypy suggested modifications to our code.

---------

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
@dtrifiro dtrifiro deleted the bump-ubi-base-image-tag branch May 20, 2024 10:12
heyselbi pushed a commit to heyselbi/vllm that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants