Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace \u0002, \u0003 in common text #521

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

drunkpig
Copy link
Collaborator

@drunkpig drunkpig commented Sep 2, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

5.pdf

Motivation

some digital pdf will produce \u002, \u003 in markdown result. This cause by pymupdf , wen just replace these special chars.
\u0000 (NUL): Null character
\u0001 (SOH): Start of Header
\u0002 (STX): Start of Text
\u0003 (ETX): End of Text
\u0004 (EOT): End of Transmission
\u0005 (ENQ): Enquiry
\u0006 (ACK): Acknowledge
\u0007 (BEL): Bell (causes an alert sound)
\u0008 (BS): Backspace
\u0009 (HT): Horizontal Tab
\u000A (LF): Line Feed (New Line)
\u000B (VT): Vertical Tab
\u000C (FF): Form Feed
\u000D (CR): Carriage Return
\u000E (SO): Shift Out
\u000F (SI): Shift In

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • [ x] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [x ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • [x ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • [ x] CLA has been sign

ed and all committers have signed the CLA in this PR.

@drunkpig drunkpig changed the title fix replace \u0002, \u0003 in common text fix: replace \u0002, \u0003 in common text Sep 2, 2024
@drunkpig drunkpig merged commit 83e0d55 into opendatalab:dev Sep 2, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant