-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: faster ci #3235
Open
bolinocroustibat
wants to merge
22
commits into
master
Choose a base branch
from
faster-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ci: faster ci #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8077755
to
74972a2
Compare
74972a2
to
bcb6e17
Compare
This reverts commit b61f3d2.
7edd80a
to
4e7cab2
Compare
568d2b6
to
724b34b
Compare
…still being executed in first executor as well
724b34b
to
cec8a68
Compare
cec8a68
to
1e94627
Compare
1e94627
to
6153958
Compare
6e7b77b
to
25575fa
Compare
25575fa
to
5e164a3
Compare
maudetes
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear about the way it works, but don't we now have 1,4K tests instead of 2K?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python
job using 2 CircleCI executors, similar to what have been done in ci: parellelize tests in CI datagouv/hydra#238, except than here, the tests that are executed in parallel must be manually specified in the CI file, since some tests can't be parallelised. Therefore, the CI code is more complicated.Building CI workflow is now around 1m40s faster on average compared to before parallelisation (which is ~30% faster , thanks to ~45% faster specifically on the
python-tests
step)Before:
![Screenshot 2024-12-23 at 23 39 56](https://private-user-images.githubusercontent.com/4353767/398186970-e25cf733-0927-493c-98fa-b42a145fd66b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNDA2MjIsIm5iZiI6MTczOTE0MDMyMiwicGF0aCI6Ii80MzUzNzY3LzM5ODE4Njk3MC1lMjVjZjczMy0wOTI3LTQ5M2MtOThmYS1iNDJhMTQ1ZmQ2NmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMjIzMjAyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDE0ZThkY2UzNTEzMDRhODI3Y2MyNTBkZWE3YTBjNDhlNWUwMTBmMWU4MzlmYjQ2NWUxMmFiYWE0NjBhMmU5ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.FQMduJFz6IaCAC9iQ0tgKzpkJpkFaXlJcEr7zTQ_eCo)
After:
![Screenshot 2024-12-23 at 23 39 12](https://private-user-images.githubusercontent.com/4353767/398186953-b90c9dfc-7a5d-4ef4-8da0-444c79038cda.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNDA2MjIsIm5iZiI6MTczOTE0MDMyMiwicGF0aCI6Ii80MzUzNzY3LzM5ODE4Njk1My1iOTBjOWRmYy03YTVkLTRlZjQtOGRhMC00NDRjNzkwMzhjZGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMjIzMjAyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjRhY2VhNjEyNDUxNDU0OWMzZWFlMDlhMzY4ZGU2MmQ0MmVjOTM1YTNkYTE0OGNlZDJiMTkyMTY1YWQ3NDI3NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.7RGeTgTaJPIIlQkBa59VuhpsTrOVErrhDp2TGtWWm_s)
inv tests
task so we can pass specific tests, to be used by parallelizationFYI, this other strategies to improve CI speed have also been tried and abandoned:
assets
job using 3 CircleCI executors. -> While this was working well, this didn't result in any time gain as it was already probably executed in parallelDisadvantage: many issues related to the command not being recognized in later steps