New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix directory for manifest classspath #54

Merged

adamkorynta merged 1 commit into opendcs:main from adamkorynta:bugfix/manifest_libs_dir

Dec 6, 2023

Contributor

adamkorynta commented Dec 6, 2023

Problem Description

Manifest classpath was looking for jars in the root directory.

Solution

Prepend the "libs/" directory during the manifest creation.

how you tested the change

Tested through the bash script.

Where the following done:

Tests. Check all that apply:
- Unit tests created or modified that run during ant test.
- Integration tests created or modified that run during integration testing
  (Formerly called regression tests.)
- Test procedure descriptions for manual testing
Was relevant documentation updated?
Were relevant config element (e.g. XML data) updated as appropriate


          fix directory for manifest classspath

384e0f2

adamkorynta requested review from MikeNeilson and wjonassen

December 6, 2023 21:19

MikeNeilson approved these changes

View reviewed changes

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

adamkorynta merged commit 5c971c2 into opendcs:main

3 checks passed

adamkorynta deleted the bugfix/manifest_libs_dir branch

December 6, 2023 22:03

adamkorynta linked an issue

that may be closed by this pull request

GitHub Actions: Packaging #31

Closed

adamkorynta added this to the 2 - Setting up CI/CD milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet