Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan web client webapp directory in the sonarqube plugin #74

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

adamkorynta
Copy link
Contributor

Problem Description

SonarQube plugin was not scanning javascript classes.

Solution

Update the sources directory to include both java and webapp directories.

how you tested the change

Testing in this PR.

Where the following done:

  • Were relevant config element (e.g. XML data) updated as appropriate

@adamkorynta adamkorynta force-pushed the devops/sonar_javascript branch 3 times, most recently from 44aee8c to d70fe1e Compare December 12, 2023 19:58
@adamkorynta adamkorynta force-pushed the devops/sonar_javascript branch 2 times, most recently from e6cbcc5 to 8f7d825 Compare December 12, 2023 21:30
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@adamkorynta adamkorynta merged commit dfb2c4c into opendcs:main Dec 12, 2023
11 checks passed
@adamkorynta adamkorynta deleted the devops/sonar_javascript branch December 12, 2023 22:05
@adamkorynta adamkorynta linked an issue Dec 13, 2023 that may be closed by this pull request
@adamkorynta adamkorynta added this to the 2 - Setting up CI/CD milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

GitHub Actions: Static Code Analysis
2 participants