Bug Fixes on start script for rest api jetty. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to get each sub project building and running properly, except for web-client-jetty.
MikeNeilson
requested changes
Jan 4, 2024
opendcs-rest-api-jetty/src/main/java/org/opendcs/odcsapi/jetty/Start.java
Show resolved
Hide resolved
Reducing servlet-api back to 3.1.0, updating build.gradle to create the bin directory if it does not exist, removing unnecessary comment in Start.java.
wjonassen
commented
Jan 4, 2024
|
Work performed for: #38 |
…ts for the user to run these projects once it has been built. Also, the beginnings of using slf4j alongside logback.
Added logging using slf4j in Start.java. This includes parsing user entered logging.properties file, as well as having a default file. One security issue was fixed in Start.java as well, no more printStackTrace.
wjonassen
commented
Jan 16, 2024
opendcs-rest-api-jetty/src/main/java/org/opendcs/odcsapi/jetty/Start.java
Outdated
Show resolved
Hide resolved
wjonassen
commented
Jan 16, 2024
opendcs-web-client-jetty/src/main/java/org/opendcs/odcswebclient/jetty/Start.java
Outdated
Show resolved
Hide resolved
adamkorynta
requested changes
Jan 16, 2024
opendcs-rest-api-jetty/src/main/java/org/opendcs/odcsapi/jetty/Start.java
Outdated
Show resolved
Hide resolved
opendcs-web-client-jetty/src/main/java/org/opendcs/odcswebclient/jetty/Start.java
Show resolved
Hide resolved
adamkorynta
reviewed
Jan 17, 2024
opendcs-rest-api-jetty/build.gradle
Outdated
| """ | ||
| } | ||
| } | ||
|
|
||
| task createLoggingPropertiesFile() { |
There was a problem hiding this comment.
I think this one shouldn't get created in gradle, it should be a resource file that gets copied over
adamkorynta
reviewed
Jan 17, 2024
| { | ||
| DbInterface.setDatabaseType(dbType); | ||
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
Do we want to continue if this throws an exception? Also if dbType is not null we are double logging
adamkorynta
reviewed
Jan 17, 2024
| @@ -166,31 +176,42 @@ else if ("siteNameTypePreference".equalsIgnoreCase(n)) | |||
| { | |||
| afr.read(); | |||
| } | |||
| catch(Exception ex) | |||
| catch(Exception e) | |||
There was a problem hiding this comment.
The previous logic exited (by throwing an exception), but now it will continue.
move logging.properties out of resources
…functionality into Start.java.
|
adamkorynta
approved these changes
Jan 17, 2024
This was
linked to
issues
Jan 17, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to get each sub project building and running properly, except for web-client-jetty.
Problem Description
Fixes #.
Describe the problem you are trying to solve.
Solution
Describe your solution.
how you tested the change
Describe what was done to test the change. This section can be left blank
if automated tests demonstrating usage are provided in the PR.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.