Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security findings on the web-client. #97

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Fix security findings on the web-client. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c41ed
Updated target="_blank" code to use rel="noopener".
wjonassen Jan 17, 2024
df261b7
Added dataTables.rowReorder.min.js and changed sources.jsp to use the…
wjonassen Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions opendcs-web-client/src/main/webapp/resources/js/datatables/dataTables.rowReorder.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion opendcs-web-client/src/main/webapp/resources/jsp/footers/decodes.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

<li class="nav-item"><a
href="<% String swaggerUrl = (String) request.getAttribute("api_swaggerui_url"); %><%= swaggerUrl %>"
class="nav-link" target="_blank"> <i class="icon-code"></i> <span>
class="nav-link" target="_blank" rel="noopener"> <i class="icon-code"></i> <span>
API Swagger UI </span>
</a>
</ul>
Expand Down
6 changes: 1 addition & 5 deletions opendcs-web-client/src/main/webapp/sources.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
</div>
<div id="displayedId" class="displayNone"></div>
<div class="modal-body opendcs-modal-body-100 d-flex flex-column">
<!--<h6 class="font-weight-semibold">Network List Name</h6>-->
<div class="card w-100 p-3">
<div class="row smallMarginBottom">

Expand Down Expand Up @@ -136,8 +135,6 @@
</div>

<div class="modal-footer">
<!--<button type="button" class="btn btn-link" data-dismiss="modal">Close</button>-->
<!-- <button type="button" class="btn btn-danger mr-auto" id="deleteSourceModalButton">Delete</button> -->
<button type="button" class="btn btn-secondary"
id="cancelSourcesModalButton" data-dismiss="modal">Cancel</button>
<button type="button" class="btn btn-success"
Expand All @@ -151,7 +148,6 @@
<jsp:include page="/resources/jsp/includes/decodes.jsp" />
<script src="../resources/js/datatables/helpers.js"></script>
<script src="../resources/js/sources.js"></script>
<script
src="https://cdn.datatables.net/rowreorder/1.2.8/js/dataTables.rowReorder.min.js"></script>
<script src="../resources/js/datatables/dataTables.rowReorder.min.js"></script>

</html>
Loading