Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wkhtmltox hangs #66

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Fix wkhtmltox hangs #66

merged 9 commits into from
Nov 18, 2021

Conversation

segator
Copy link
Contributor

@segator segator commented Nov 17, 2021

This PR fixes #64 and improve memory managment migrating from byte[] to Java Streams.

@segator
Copy link
Contributor Author

segator commented Nov 17, 2021

Testing is still needed before merging!

@clemensutschig
Copy link
Member

Isaac thank you for the path - but I am lost - why did the intents etc change now - this makes this mega hard to read and understand... :(

@segator
Copy link
Contributor Author

segator commented Nov 18, 2021

The failed Pipeline is a known issue, can be ignored.

@segator segator merged commit c4945ac into master Nov 18, 2021
@segator segator deleted the fix/memoryManagment branch November 18, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render big PDF files makes wkhtmltox freeze
3 participants