Improve memory management and error handling #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafarre-bi
commented
Dec 15, 2021
jafarre-bi
commented
- Using temporary files, input/output streams or scratch files instead of fully loading files into memory.
- Improved error handling.
- Temporary files are now guarranted to be removed when not needed anymore.
- Created generic utility class and extension to simplify temporary-file management.
- Fixed bugs in the /health endpoint.
- Small miscellaneous improvements and many warnings removed.
jafarre-bi
requested review from
angelmp01,
clemensutschig,
hrcornejo,
jorge-romero and
s2oBCN
jafarre-bi
force-pushed
the
feature/EDPC-1071
branch
2 times, most recently
from
aa69bc9
to
64715d6
Compare
jafarre-bi
force-pushed
the
feature/EDPC-1071
branch
from
64715d6
to
5c79276
Compare
|
We have detected a problem with the packaging of the app.jar, so this cannot be merged yet. Apparently, the problem was always there, but it doesn't always manifest. |
Add a modified transformer for module descriptors in META-INF/groovy
|
The fix required activating the mergeGroovyExtensionModules transformation of the shadowJar plugin and also working around a bug in the plugin code. |
jafarre-bi
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Improve memory management and error handling Co-authored-by: zxBCN Farre_Basurte,Juan_Antonio (IT EDS) EXTERNAL <juan_antonio.farre_basurte.ext@boehringer-ingelheim.com> (cherry picked from commit def9b0c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.