Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset env_info #845

Closed
Tracked by #548
neal2164 opened this issue Dec 1, 2024 · 1 comment
Closed
Tracked by #548

Reset env_info #845

neal2164 opened this issue Dec 1, 2024 · 1 comment
Labels
bug Something isn't working env Questions about RL environment

Comments

@neal2164
Copy link

neal2164 commented Dec 1, 2024

There should be a line like "env_info[timestep.env_id.item()] = {'time': 0., 'step': 0, 'train_sample': 0}" here. Otherwise, the value of env_info keeps accumulating and doesn't represent the intended statistics anymore.

@PaParaZz1 PaParaZz1 added bug Something isn't working env Questions about RL environment labels Dec 2, 2024
@PaParaZz1
Copy link
Member

Thanks for your feedback. We have added this reset mechanism for env_info in the above commit, add related unittest modules are also improved to check its correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env Questions about RL environment
Projects
None yet
Development

No branches or pull requests

2 participants