Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo(nyz): slime volleyball league training #229

Merged
merged 7 commits into from
Mar 19, 2022
Merged

Conversation

PaParaZz1
Copy link
Member

@PaParaZz1 PaParaZz1 commented Mar 1, 2022

Description

  • adapt slime volleyball env
  • slime volleyball league demo
  • tune param
  • remove prob viz in evaluator

Related Issue

#90

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the env Questions about RL environment label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #229 (780fd92) into main (d9b8a11) will decrease coverage by 0.05%.
The diff coverage is 98.64%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   85.82%   85.77%   -0.06%     
==========================================
  Files         459      466       +7     
  Lines       34795    36560    +1765     
==========================================
+ Hits        29863    31358    +1495     
- Misses       4932     5202     +270     
Flag Coverage Δ
unittests 85.77% <98.64%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...orker/collector/battle_episode_serial_collector.py 14.19% <ø> (-71.44%) ⬇️
ding/league/base_league.py 85.82% <93.75%> (+1.00%) ⬆️
ding/entry/application_entry.py 85.18% <100.00%> (+0.42%) ⬆️
ding/league/shared_payoff.py 97.34% <100.00%> (+9.27%) ⬆️
ding/league/tests/test_one_vs_one_league.py 99.01% <100.00%> (+0.35%) ⬆️
ding/league/tests/test_payoff.py 99.06% <100.00%> (+0.01%) ⬆️
ding/policy/ppo.py 86.30% <100.00%> (+0.04%) ⬆️
...r/collector/battle_interaction_serial_evaluator.py 88.41% <100.00%> (ø)
...g/worker/collector/interaction_serial_evaluator.py 93.80% <100.00%> (+0.11%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b8a11...780fd92. Read the comment docs.

ding/league/shared_payoff.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 marked this pull request as ready for review March 18, 2022 04:27
@zxzzz0
Copy link

zxzzz0 commented Mar 18, 2022

There is no new commit. Did you push the latest code?

@PaParaZz1
Copy link
Member Author

we will add optimal training param in the following PR.

@PaParaZz1 PaParaZz1 merged commit bb356ed into main Mar 19, 2022
@PaParaZz1 PaParaZz1 deleted the dev-league-slime branch March 19, 2022 10:30
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
* polish(nyz): adapt slime_volley env to new BaseEnv

* demo(nyz): add naive slime volleyball league training demo

* fix(nyz): fix self-play payoff bug and add player_rank viz

* polish(nyz): add more viz about slime volleyball league demo and polish config

* fix(nyz): fix unittest bugs

* polish(nyz): split action prob viz only for league demo

* polish(nyz): polish payoff variable name and slime_volley final_eval_reward definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env Questions about RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants