Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(gry): polish dqn config #611

Merged
merged 5 commits into from
Mar 20, 2023
Merged

polish(gry): polish dqn config #611

merged 5 commits into from
Mar 20, 2023

Conversation

ruoyuGao
Copy link
Contributor

@ruoyuGao ruoyuGao commented Mar 14, 2023

Description

find all the possible dqn parameters and add them into dqn default config and comment.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #611 (4825b49) into main (275141b) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 4825b49 differs from pull request most recent head f9a3f09. Consider uploading reports for the commit f9a3f09 to get more accurate results

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   83.34%   83.30%   -0.05%     
==========================================
  Files         569      569              
  Lines       46819    46819              
==========================================
- Hits        39022    39003      -19     
- Misses       7797     7816      +19     
Flag Coverage Δ
unittests 83.30% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/model/template/q_learning.py 85.82% <ø> (ø)
ding/policy/dqn.py 87.34% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 added the config Update config label Mar 15, 2023
ding/policy/dqn.py Outdated Show resolved Hide resolved
ding/policy/dqn.py Show resolved Hide resolved
ding/policy/dqn.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit 503d273 into opendilab:main Mar 20, 2023
@ruoyuGao ruoyuGao deleted the ruoyugao branch March 23, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Update config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants