Fix log messages and init progress for the profile API

This PR fixes incorrect or unnecessary log messages. The PR also specifies init progress to use ASCII explicitly. Otherwise, it is possible we may get unexpected characters. Testing done: 1. gradle build
opendistro-for-elasticsearch · Jan 27, 2021 · 4ad4706 · 4ad4706
1 parent 852c2af
commit 4ad4706
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/main/java/com/amazon/opendistroforelasticsearch/ad/AbstractProfileRunner.java b/src/main/java/com/amazon/opendistroforelasticsearch/ad/AbstractProfileRunner.java
@@ -15,6 +15,8 @@
 
 package com.amazon.opendistroforelasticsearch.ad;
 
+import java.util.Locale;
+
 import com.amazon.opendistroforelasticsearch.ad.model.InitProgressProfile;
 
 public abstract class AbstractProfileRunner {
@@ -29,7 +31,9 @@ protected InitProgressProfile computeInitProgressProfile(long totalUpdates, long
         int neededPoints = (int) (requiredSamples - totalUpdates);
         return new InitProgressProfile(
             // rounding: 93.456 => 93%, 93.556 => 94%
-            String.format("%.0f%%", percent),
+            // Without Locale.US, sometimes conversions use localized decimal digits
+            // rather than the usual ASCII digits. See https://tinyurl.com/y5sdr5tp
+            String.format(Locale.US, "%.0f%%", percent),
             intervalMins * neededPoints,
             neededPoints
         );

diff --git a/src/main/java/com/amazon/opendistroforelasticsearch/ad/EntityProfileRunner.java b/src/main/java/com/amazon/opendistroforelasticsearch/ad/EntityProfileRunner.java
@@ -227,8 +227,13 @@ private void getJob(
 
                             delegateListener.onResponse(builder.build());
                         }, exception -> {
-                            logger.warn("fail to get last sample time", exception);
                             // sth wrong like result index not created. Return what we have
+                            if (exception instanceof IndexNotFoundException) {
+                                // don't print out stack trace since it is not helpful
+                                logger.info("Result index hasn't been created", exception.getMessage());
+                            } else {
+                                logger.warn("fail to get last sample time", exception);
+                            }
                             delegateListener.onResponse(builder.build());
                         }));
                     }

diff --git a/...java/com/amazon/opendistroforelasticsearch/ad/transport/EntityProfileTransportAction.java b/...java/com/amazon/opendistroforelasticsearch/ad/transport/EntityProfileTransportAction.java
@@ -118,7 +118,7 @@ protected void doExecute(Task task, EntityProfileRequest request, ActionListener
             listener.onResponse(builder.build());
         } else {
             // redirect
-            LOG.debug("Sending RCF polling request to {} for detector {}, entity {}", nodeId, adID, entityValue);
+            LOG.debug("Sending entity profile request to {} for detector {}, entity {}", nodeId, adID, entityValue);
 
             try {
                 transportService