Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

fix job index mapping #212

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

ylwu-amzn
Copy link
Contributor

Description of changes:

Current job index mapping can't match the model class. AD job can run successfully. This PR fixes the job index mapping to match the model class.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #212 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
- Coverage     72.21%   72.20%   -0.02%     
  Complexity     1289     1289              
============================================
  Files           139      139              
  Lines          5979     5979              
  Branches        469      469              
============================================
- Hits           4318     4317       -1     
- Misses         1457     1458       +1     
  Partials        204      204              
Flag Coverage Δ Complexity Δ
#cli 79.74% <ø> (ø) 0.00 <ø> (ø)
#plugin 71.32% <ø> (-0.02%) 1289.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...asticsearch/ad/cluster/ADClusterEventListener.java 88.00% <0.00%> (-4.00%) 13.00% <0.00%> (-1.00%)
...sticsearch/ad/indices/AnomalyDetectionIndices.java 62.31% <0.00%> (+0.72%) 24.00% <0.00%> (+1.00%)

Copy link
Contributor

@yizheliu-amazon yizheliu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: why we need this fix now? What issue it is causing?

@ylwu-amzn
Copy link
Contributor Author

we need this fix now? What issue it is causing?

It doesn't cause any failure. Just make the index mapping consistent with the java model class.

@ylwu-amzn ylwu-amzn merged commit 9a0166e into opendistro-for-elasticsearch:master Aug 19, 2020
@VijayanB VijayanB added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 25, 2020
yizheliu-amazon pushed a commit that referenced this pull request Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants