Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add spotless for code format #22

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Add spotless for code format #22

merged 1 commit into from
Jan 15, 2020

Conversation

wnbts
Copy link
Contributor

@wnbts wnbts commented Dec 28, 2019

Add spotless to check and apply a standard code format.

@wnbts wnbts marked this pull request as ready for review December 28, 2019 00:37
Copy link
Member

@kaituo kaituo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add descriptions on readme on how to run spotless?

@ylwu-amzn
Copy link
Contributor

Could you add descriptions on readme on how to run spotless?

Seems the file format is for eclipse. Can it support Intellij IDEA? If I develop with Intellij IDEA, what should I do to make it compatible with this format? Can you add such information on readme too?

@wnbts
Copy link
Contributor Author

wnbts commented Jan 11, 2020

Could you add descriptions on readme on how to run spotless?

done.

@wnbts
Copy link
Contributor Author

wnbts commented Jan 11, 2020

Could you add descriptions on readme on how to run spotless?

Seems the file format is for eclipse. Can it support Intellij IDEA? If I develop with Intellij IDEA, what should I do to make it compatible with this format? Can you add such information on readme too?

Intellij support eclipse format files.

@ylwu-amzn
Copy link
Contributor

Could you add descriptions on readme on how to run spotless?

Seems the file format is for eclipse. Can it support Intellij IDEA? If I develop with Intellij IDEA, what should I do to make it compatible with this format? Can you add such information on readme too?

Intellij support eclipse format files.

Thanks. Got it.
Open IntelliJ IDEA Settings → Code Style → Java, click Manage, and import that XML file by simply clicking Import.
Once import eclipse format file, we can use Intelij IDEA auto format short cut correctly.

Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unified code format is good practice. Thanks a lot.

@wnbts wnbts merged commit 1637128 into opendistro-for-elasticsearch:development Jan 15, 2020
@wnbts wnbts deleted the spotless branch June 17, 2020 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants