This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
CLI: Update Detector Configurations #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
wnbts,
kaituo,
yizheliu-amazon and
ylwu-amzn
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage ? 72.90%
Complexity ? 1331
=========================================
Files ? 149
Lines ? 6194
Branches ? 480
=========================================
Hits ? 4516
Misses ? 1453
Partials ? 225
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Update Feature Workflow:
|
kaituo
approved these changes
Sep 25, 2020
ylwu-amzn
reviewed
Oct 6, 2020
cli/cmd/update.go
Outdated
| const ( | ||
| commandUpdate = "update" | ||
| flagForce = "force" | ||
| flagRestart = "restart" |
There was a problem hiding this comment.
User can only "restart" a running detector? If current detector hasn't been started, is it possible user only set "restart" as true to start it after update ?
From the description "Will start detector if update is successful", it's better to name the flag as "start".
ylwu-amzn
reviewed
Oct 6, 2020
cli/internal/controller/ad/ad.go
Outdated
| if !proceed { | ||
| return nil | ||
| } | ||
| err := c.StopDetector(ctx, input.ID) |
There was a problem hiding this comment.
If "force" is false, no need to stop detector.
ylwu-amzn
reviewed
Oct 6, 2020
| if latestDetector.LastUpdatedAt > input.LastUpdatedAt { | ||
| return fmt.Errorf( | ||
| "new version for detector is available. Please fetch latest version and then merge your changes") | ||
| } |
There was a problem hiding this comment.
Check if detector is running? If detector is running and force is false, we should fail immediately.
Add Update detector method to call update rest api.
Create Update Detector Entity as an alias from Create Detector.
Add mapper function to map user input to request
Add controller method to update detecor based on configurations.
Added handler to process user input and call controller method, later process output from controller for command status.
Create Update command to accept update detector's configuration.
Updated restart to start Only stop detector if force is true
ylwu-amzn
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Detector Configurations
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.