This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
upgrade rcf libaries #239
Merged
upgrade rcf libaries #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
============================================
+ Coverage 72.24% 72.66% +0.41%
- Complexity 1304 1330 +26
============================================
Files 146 149 +3
Lines 6043 6101 +58
Branches 476 480 +4
============================================
+ Hits 4366 4433 +67
+ Misses 1463 1450 -13
- Partials 214 218 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saratvemulapalli
approved these changes
Oct 2, 2020
kaituo
reviewed
Oct 2, 2020
| @@ -298,8 +298,8 @@ dependencies { | |||
| compile group: 'com.yahoo.datasketches', name: 'sketches-core', version: '0.13.4' | |||
| compile group: 'com.yahoo.datasketches', name: 'memory', version: '0.12.2' | |||
| compile group: 'commons-lang', name: 'commons-lang', version: '2.6' | |||
| compile 'software.amazon.randomcutforest:randomcutforest-core:1.0-alpha' | |||
| compile 'software.amazon.randomcutforest:randomcutforest-serialization-json:1.0-alpha' | |||
There was a problem hiding this comment.
Double check: 1.0 includes aws/random-cut-forest-by-aws@7b27ed9, right?
There was a problem hiding this comment.
kaituo
approved these changes
Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr upgrades rcf libraries to the current version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.