This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding RestActions support for Get Detector API #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
- Coverage 72.86% 71.57% -1.29%
- Complexity 1329 1350 +21
============================================
Files 149 153 +4
Lines 6194 6406 +212
Branches 480 490 +10
============================================
+ Hits 4513 4585 +72
- Misses 1456 1589 +133
- Partials 225 232 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
reviewed
Oct 9, 2020
| public XContentBuilder toXContent(XContentBuilder builder) throws IOException { | ||
| return toXContent(builder, ToXContent.EMPTY_PARAMS); | ||
| } | ||
|
|
||
| public void writeTo(StreamOutput output) throws IOException { |
There was a problem hiding this comment.
Should we override Writeable.writeTo method like Feature class?
There was a problem hiding this comment.
Sure thats a good point.
Will make changes for both AnomalyDetector and AnomalyDetectorJob
ohltyler
approved these changes
Oct 12, 2020
ylwu-amzn
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding RestActions support for Get Detector API
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.