This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Adding RestActions support for Start/Stop Detector API #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/amazon/opendistroforelasticsearch/ad/transport/AnomalyDetectorJobAction.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
============================================
+ Coverage 71.70% 72.15% +0.44%
- Complexity 1368 1387 +19
============================================
Files 157 160 +3
Lines 6513 6582 +69
Branches 493 495 +2
============================================
+ Hits 4670 4749 +79
+ Misses 1611 1599 -12
- Partials 232 234 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ohltyler
reviewed
Oct 12, 2020
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Oct 12, 2020
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Oct 12, 2020
...va/com/amazon/opendistroforelasticsearch/ad/transport/AnomalyDetectorJobTransportAction.java
Outdated
Show resolved
Hide resolved
ohltyler
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ylwu-amzn
reviewed
Oct 13, 2020
...com/amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorActionHandler.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding RestActions support for Start/Stop Detector API which is needed to support AD FGAC
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.