This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Add checkpoint index retention for multi entity detector #283
Merged
weicongs-amazon
merged 7 commits into
opendistro-for-elasticsearch:master
from
weicongs-amazon:checkpoint-cleanup
Nov 6, 2020
Merged
Add checkpoint index retention for multi entity detector #283
weicongs-amazon
merged 7 commits into
opendistro-for-elasticsearch:master
from
weicongs-amazon:checkpoint-cleanup
Nov 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
============================================
- Coverage 73.22% 72.22% -1.01%
- Complexity 1749 1987 +238
============================================
Files 180 201 +21
Lines 8119 9547 +1428
Branches 670 847 +177
============================================
+ Hits 5945 6895 +950
- Misses 1864 2238 +374
- Partials 310 414 +104
Flags with carried forward coverage won't be shown. Click here to find out more. |
weicongs-amazon
changed the title
Add checkpoint index retention for multi entity detector - [WIP]
Add checkpoint index retention for multi entity detector
Oct 21, 2020
kaituo
approved these changes
Oct 21, 2020
ylwu-amzn
reviewed
Nov 6, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/cluster/diskcleanup/IndexCleanup.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Nov 6, 2020
.../amazon/opendistroforelasticsearch/ad/cluster/diskcleanup/ModelCheckpointIndexRetention.java
Show resolved
Hide resolved
ylwu-amzn
reviewed
Nov 6, 2020
.../amazon/opendistroforelasticsearch/ad/cluster/diskcleanup/ModelCheckpointIndexRetention.java
Show resolved
Hide resolved
ylwu-amzn
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add checkpoint index retention logic for multi entity detectors.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.