Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

fix double nan error when parse to json #310

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

ylwu-amzn
Copy link
Contributor

Issue #, if available:

Description of changes:
new Gson().toJson(Double.NaN) will throw such exception: "NaN is not a valid double value as per JSON specification"
This PR fixed this bug

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #310 (e2da1a2) into master (75db58b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #310      +/-   ##
============================================
- Coverage     72.23%   72.20%   -0.04%     
+ Complexity     1993     1992       -1     
============================================
  Files           201      201              
  Lines          9567     9567              
  Branches        849      849              
============================================
- Hits           6911     6908       -3     
- Misses         2245     2247       +2     
- Partials        411      412       +1     
Flag Coverage Δ Complexity Δ
plugin 71.63% <100.00%> (-0.04%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java 94.82% <100.00%> (ø) 11.00 <1.00> (ø)
...port/SearchAnomalyDetectorInfoTransportAction.java 54.54% <0.00%> (-4.55%) 4.00% <0.00%> (ø%)
...asticsearch/ad/cluster/ADClusterEventListener.java 92.00% <0.00%> (-2.00%) 14.00% <0.00%> (-1.00%)

@ylwu-amzn ylwu-amzn merged commit 28410da into opendistro-for-elasticsearch:master Nov 10, 2020
@weicongs-amazon weicongs-amazon added the bug Something isn't working label Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants