Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix issue where data hole exists for Preview API #312

Conversation

yizheliu-amazon
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix issue where data hole exists for Preview API. For now, we only get cold start samples with non-zero doc, and we add samples to corresponding date range by index of cold start samples. This can cause issue because when source data has no doc in periods of time, size of featureSamples is less than sampleRanges, then only the some beginning date ranges of sampleRanges have data returned.

Fix is simple: just include zero count bucket in the response from ES.

Example: data only exists in source starting from 11-13-2020
Before:
Screen Shot 2020-11-14 at 5 24 12 PM

After:
Screen Shot 2020-11-14 at 5 22 53 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yizheliu-amazon yizheliu-amazon added the bug Something isn't working label Nov 17, 2020
@yizheliu-amazon
Copy link
Contributor Author

Checks are failing because set-env is disabled. Have run gradle build locally to make sure all tests pass

@kaituo
Copy link
Member

kaituo commented Nov 18, 2020

Checks are failing because set-env is disabled. Have run gradle build locally to make sure all tests pass

Weicong's PR fixed it.

@yizheliu-amazon yizheliu-amazon merged commit 5d30bb9 into opendistro-for-elasticsearch:master Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants