This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix issue where data hole exists for Preview API #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix issue where data hole exists for Preview API. For now, we only get cold start samples with non-zero doc, and we add samples to corresponding date range by index of cold start samples. This can cause issue because when source data has no doc in periods of time, size of
featureSamples
is less thansampleRanges
, then only the some beginning date ranges ofsampleRanges
have data returned.Fix is simple: just include zero count bucket in the response from ES.
Example: data only exists in source starting from 11-13-2020
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.