This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix detector and feature serialization #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
============================================
+ Coverage 72.11% 72.92% +0.80%
- Complexity 1985 2000 +15
============================================
Files 201 201
Lines 9558 9563 +5
Branches 850 852 +2
============================================
+ Hits 6893 6974 +81
+ Misses 2256 2176 -80
- Partials 409 413 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| if (input.readBoolean()) { | ||
| this.user = new User(input); | ||
| } else { | ||
| user = null; | ||
| } | ||
| if (input.readBoolean()) { |
There was a problem hiding this comment.
just curious: why readBoolean being true indicates uiMetadata can be read from readMap()
There was a problem hiding this comment.
We write true if uiMetadata is not null in the writeTo method: check https://github.com/opendistro-for-elasticsearch/anomaly-detection/pull/322/files#diff-ab4bf6eb04e845b21b1182e30afb84c73b282bae5cc26dbcfef2e846211bcdecR248
yizheliu-amazon
approved these changes
Dec 3, 2020
saratvemulapalli
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Detector and feature serialization has issue, see such error:
Changes
This PR fixed serialization of anomaly detector and feature by writing to and reading from stream.
Test
1.Add unit test cases for serialization of anomaly detector and feature
2.
./gradlew buildpass3.
./gradlew runand testBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.