This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Adding role based filtering for rest of APIs #325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
- Coverage 74.39% 73.62% -0.77%
+ Complexity 2022 2020 -2
============================================
Files 201 201
Lines 9563 9664 +101
Branches 852 860 +8
============================================
+ Hits 7114 7115 +1
- Misses 2019 2116 +97
- Partials 430 433 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...va/com/amazon/opendistroforelasticsearch/ad/transport/AnomalyDetectorJobTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/util/ParseUtils.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Dec 8, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/util/ParseUtils.java
Outdated
Show resolved
Hide resolved
yizheliu-amazon
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the change
ylwu-amzn
approved these changes
Dec 9, 2020
…stro-for-elasticsearch/anomaly-detection into fgac-role-based-filtering
kaituo
reviewed
Dec 10, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/util/ParseUtils.java
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/util/ParseUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/util/ParseUtils.java
Show resolved
Hide resolved
...t/java/com/amazon/opendistroforelasticsearch/ad/transport/AnomalyDetectorJobActionTests.java
Show resolved
Hide resolved
...t/java/com/amazon/opendistroforelasticsearch/ad/transport/AnomalyDetectorJobActionTests.java
Outdated
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/ad/transport/IndexAnomalyDetectorTransportActionTests.java
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/ad/transport/IndexAnomalyDetectorTransportActionTests.java
Show resolved
Hide resolved
kaituo
approved these changes
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding backend user role based filtering to
Delete, Start/Stop, Get/Profile and Update
APIs.Also added support to block users creating detectors when AD Backend Role based filtering is turned on and user does not have backend roles.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.