This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Backport: Fix the profile API returns prematurely. (#340) #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asticsearch#340) Besides backporting, this PR also: First, it fixes another premature return in AnomalyDetectorProfileRunner.onInittedEver. Second, it replaces set-env with GITHUB_ENV so that backport PR can invoke CI. The `set-env` command is disabled. Testing done: 1. Verfied manually the new early return bug is fixed.. 2. Manual tests to run profile calls for single-stream and multi-entity detectors for different phases of the detector lifecycle (disabled, init, running). Verified profile results make sense.
Codecov Report
@@ Coverage Diff @@
## opendistro-1.11 #343 +/- ##
==================================================
Coverage ? 72.73%
Complexity ? 2009
==================================================
Files ? 201
Lines ? 9565
Branches ? 850
==================================================
Hits ? 6957
Misses ? 2198
Partials ? 410
Flags with carried forward coverage won't be shown. Click here to find out more. |
yizheliu-amazon
approved these changes
Dec 29, 2020
ylwu-amzn
approved these changes
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Besides backporting, this PR also:
First, it fixes another premature return in AnomalyDetectorProfileRunner.onInittedEver.
Second, it replaces set-env with GITHUB_ENV so that backport PR can invoke CI. The
set-envcommand is disabled.Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.