Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change release workflow to use new staging bucket for artifacts #358

Merged

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 9, 2021

Issue #, if available:

Description of changes:
The infrastructure team is separating the production and staging locations into different AWS accounts. Plugins need to modify their workflows to publish to the new locations.

This PR changes the CD workflow to add a build number and write the zip, deb, and rpm plugin artifacts to staging.artifacts.opendistroforelasticsearch.amazon.com.

Test Results:
https://github.com/gaiksaya/anomaly-detection/runs/1684584738?check_suite_focus=true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #358 (bcb0510) into master (19b8f9d) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
+ Coverage     78.65%   78.69%   +0.03%     
+ Complexity     2465     2462       -3     
============================================
  Files           224      224              
  Lines         10995    10995              
  Branches        943      943              
============================================
+ Hits           8648     8652       +4     
+ Misses         1907     1902       -5     
- Partials        440      441       +1     
Flag Coverage Δ Complexity Δ
plugin 78.64% <ø> (+0.03%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...asticsearch/ad/cluster/ADClusterEventListener.java 92.00% <0.00%> (-2.00%) 14.00% <0.00%> (-1.00%)
...troforelasticsearch/ad/task/ADBatchTaskRunner.java 85.42% <0.00%> (-0.88%) 57.00% <0.00%> (-1.00%)
...sticsearch/ad/indices/AnomalyDetectionIndices.java 50.32% <0.00%> (-0.33%) 44.00% <0.00%> (-1.00%)
...stroforelasticsearch/ad/AnomalyDetectorRunner.java 46.25% <0.00%> (+6.25%) 7.00% <0.00%> (+1.00%)
...port/SearchAnomalyDetectorInfoTransportAction.java 63.63% <0.00%> (+9.09%) 4.00% <0.00%> (ø%)

@gaiksaya gaiksaya added the infra label Jan 9, 2021
@kaituo
Copy link
Member

kaituo commented Jan 11, 2021

Are you using the latest mater branch? The build has tests failure.

@gaiksaya gaiksaya force-pushed the release-workflow-patch branch from 03cb8f3 to 7bc0065 Compare January 11, 2021 22:16
@gaiksaya
Copy link
Member Author

Are you using the latest mater branch? The build has tests failure.

Hi @kaituo , I updated my branch and fork with recent master. Tests seems to be passing now. Thanks!

@gaiksaya gaiksaya marked this pull request as draft January 12, 2021 18:28
Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@gaiksaya gaiksaya marked this pull request as ready for review February 1, 2021 21:52
@gaiksaya gaiksaya changed the title [WIP] Change release workflow to use new staging bucket for artifacts Change release workflow to use new staging bucket for artifacts Feb 1, 2021
@gaiksaya gaiksaya merged commit bf2391f into opendistro-for-elasticsearch:master Feb 1, 2021
@gaiksaya gaiksaya deleted the release-workflow-patch branch February 1, 2021 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants