This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
adjust preview configuration for more data #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
reviewed
Feb 1, 2020
| @@ -317,7 +321,8 @@ public void getPreviewFeatures(AnomalyDetector detector, long startMilli, long e | |||
| long end = truncateToMinute(endMilli); | |||
| long bucketSize = ((IntervalTimeConfiguration) detector.getDetectionInterval()).toDuration().toMillis(); | |||
| int numBuckets = (int) Math.floor((end - start) / (double) bucketSize); | |||
| int stride = (int) Math.max(1, Math.floor((double) numBuckets / maxPreviewSamples)); | |||
| int numSamples = (int) Math.min(numBuckets * previewSampleRate, maxPreviewSamples); | |||
There was a problem hiding this comment.
Suggestion,
int numSamples = Math.max(1, (int) Math.min(numBuckets * previewSampleRate, maxPreviewSamples));
to avoid numSamples being 0.
jngz-es
approved these changes
Feb 1, 2020
ylwu-amzn
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for preview requests, up to 60 data points are sampled and up to 200 results are returned to the client to reduce latency from processing and network. To improve visualization for human eyes, the changes increase the number of samples to match the requested time range, the upper limit of samples, and the number of returned results to clients.