This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
add AD job on top of JobScheduler #44
Merged
ylwu-amzn
merged 6 commits into
opendistro-for-elasticsearch:development
from
ylwu-amzn:development
Feb 27, 2020
Merged
add AD job on top of JobScheduler #44
ylwu-amzn
merged 6 commits into
opendistro-for-elasticsearch:development
from
ylwu-amzn:development
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
reviewed
Feb 24, 2020
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Show resolved
Hide resolved
...java/com/amazon/opendistroforelasticsearch/ad/rest/handler/AnomalyDetectorActionHandler.java
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Show resolved
Hide resolved
...main/java/com/amazon/opendistroforelasticsearch/ad/rest/RestDeleteAnomalyDetectorAction.java
Show resolved
Hide resolved
...main/java/com/amazon/opendistroforelasticsearch/ad/rest/RestDeleteAnomalyDetectorAction.java
Show resolved
Hide resolved
ylwu-amzn
commented
Feb 27, 2020
} | ||
} | ||
ToXContent.Params params = new ToXContent.MapParams(ImmutableMap.of(ENABLED_FIELD, adJobEnabled.toString())); | ||
builder.field(RestHandlerUtils.ANOMALY_DETECTOR, detector, params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To limit PR size. Will publish another PR to return both detector and detector job.
kaituo
approved these changes
Feb 27, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/AnomalyDetectorJobRunner.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/model/AnomalyDetectorJob.java
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/rest/RestAnomalyDetectorJobAction.java
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorJobActionHandler.java
Outdated
Show resolved
Hide resolved
yizheliu-amazon
approved these changes
Feb 27, 2020
Closed
kaituo
pushed a commit
to kaituo/anomaly-detection
that referenced
this pull request
Mar 6, 2020
* add AD job on top of JobScheduler * release job lock when job finish or fail * upgrade jobscheduler to 1.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create AD job on top of JobScheduler. User can create monitor on AD result index. So we can decouple AD and Alerting.