support return AD job when get detector

[ylwu-amzn]

• Add job disabled time
• Support return AD job when get detector if set ?job=true
• Tune start job logic:
  1). If job not exists, create new job.
  2). If job exists: a). if job state is enabled, return warning message; b). if job state is disabled, enable job.
• Tune stop job logic:
  1). If job not exists, return error message
  2). If job exists: a).if job state is disabled, return warning message; b).if job state is enabled, disable job and stop AD model.
• Tune delete detector logic:
  1). If no AD job index or AD job not found or AD job is disabled, delete detector directly
  2). If AD job state is enabled, return warning message, not delete detector

[kaituo]

so function does not send back response using channel?

[ylwu-amzn]

Function will send back response.
Check line 287 of file IndexAnomalyDetectorJobActionHandler

stopAdDetectorListener(channel, detectorId)

[kaituo]

Any way to enforce sending back response? It is easy for function implementor to forget to add a channel.sendResponse.

[ylwu-amzn]

This is a private function and it doesn't implicitly require to send response to channel here. Depends on how developer implements the logic.

[kaituo]

AnomalyDetectorFunction is too general and can be anything. We want to make an interface specific for a specific thing. I would suggest:

1. rename AnomalyDetectorFunction to ListenerWithChannel or sth that is more specific
2. make execute take channel as a parameter
3. add a comment before channel indicating user should send channel response.

[ylwu-amzn]

We can do that. How about we split such refactoring work into another issue. So we can make this PR more focusing. Thanks for the suggestion.