This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add async stopModel #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
approved these changes
May 5, 2020
kaituo
reviewed
May 5, 2020
| @@ -537,10 +537,50 @@ public void stopModel(String detectorId, String modelId) { | |||
| Optional | |||
| .ofNullable(models.remove(modelId)) | |||
| .filter(model -> model.getLastCheckpointTime().plus(checkpointInterval).isBefore(now)) | |||
| .ifPresent(model -> { | |||
| checkpointDao.putModelCheckpoint(modelId, toCheckpoint.apply(model.getModel())); | |||
| model.setLastCheckpointTime(now); | |||
There was a problem hiding this comment.
Why is setting last checkpoint time not necessary any more?
There was a problem hiding this comment.
because the model has been removed from the managed models at line 538 and has become garbage at the end of the method.
kaituo
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current stopModel is a synchronous operation for stopping hosting models. As part of migration to asynchronous implementation, this change adds an asynchronous equivalent using the same business logic with one minor change/fix - setting lastCheckpointTime on a stopped and saved model object going into garbage collection is unnecessary and is therefore removed for cleanness.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.