This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add a method to support renewing a lock in LockService class #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftianli-amzn
requested review from
zengyan-amazon,
dbbaughe,
qreshi and
bowenlan-amzn
dbbaughe
reviewed
Oct 6, 2020
| lock, lock.getLockTime(), lock.getLockDurationSeconds()); | ||
| final LockModel lockToRenew = new LockModel(lock, getNow(), lock.getLockDurationSeconds(), false); | ||
| updateLock(lockToRenew, ActionListener.wrap( | ||
| renewedLock -> listener.onResponse(renewedLock != null), |
There was a problem hiding this comment.
I think it might be more useful to change this to return the lock itself rather than a boolean as it would be more useful to have the new updated lock in the plugin with the new seqNo/primaryTerm.
There was a problem hiding this comment.
Ok, I will change to return the lock. I have realized it could be more useful as well during writing the test.
There was a problem hiding this comment.
I have changed to return the lock object instead of a boolean value after calling the method, and also simplified the test procedure due to the change.
dbbaughe
approved these changes
Oct 7, 2020
qreshi
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When locking mechanism is enabled on a
ScheduledJob, every execution of the job have to acquire the lock to execute, in order to avoid overlapping execution. The lock will be expired after a fixed period of time, which is defined by the job.Currently there is no way to give an extension of period for an execution to hold the lock.
Description of changes:
renewLock()inLockServiceclass of the SPI.With the new method
renewLock(), it makes possible for an execution of aScheduledJobto be given an extend duration to hold a lock for running the job.When calling the method, it attempts to renew the lock.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.