This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Bump react-syntax-highlighter to fix regex dos vulnerability, fix cypress #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,7 +274,7 @@ describe('Testing paragraphs', () => { | |||
| cy.wait(delay); | |||
| cy.get('.euiContextMenuItem__text').contains('Rename notebook').click(); | |||
| cy.wait(delay); | |||
| cy.get('input.euiFieldText').type(' (rename)'); | |||
| cy.get('input.euiFieldText[data-autofocus="true"]').type(' (rename)'); | |||
There was a problem hiding this comment.
Just curious, what does the [data-autofocus="true"] flag change in this test?
There was a problem hiding this comment.
There might be other input.euiFieldText in embedded visualizations on the page, this makes sure cypress selects the input box inside the rename toast. Using custom class/id selector is better, but none of the euiFieldText in sample visualizations has autofocus, so this works as well
joshuali925
added a commit
that referenced
this pull request
Feb 1, 2021
…ress (#74) * bump highlight.js * bump react-syntax-highlighter * fix cypress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.