This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
[Bug fix] support csv report for saved search with multiple indices #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
dai-chen,
davidcui1225,
joshuali925 and
akbhatta
and removed request for
dai-chen
akbhatta
approved these changes
Dec 18, 2020
joshuali925
approved these changes
Dec 18, 2020
Codecov Report
@@ Coverage Diff @@
## dev #267 +/- ##
==========================================
+ Coverage 74.87% 74.91% +0.04%
==========================================
Files 32 32
Lines 1751 1754 +3
Branches 341 340 -1
==========================================
+ Hits 1311 1314 +3
Misses 435 435
Partials 5 5
Continue to review full report at Codecov.
|
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#262 #251 #249
Description of changes:
maxResultSize, for saved search settings with multiple indices.(usually from index-pattern using wildcard)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.