-
Notifications
You must be signed in to change notification settings - Fork 31
Support customized server config #313
Support customized server config #313
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #313 +/- ##
============================================
+ Coverage 64.16% 64.24% +0.07%
Complexity 291 291
============================================
Files 100 100
Lines 4044 4047 +3
Branches 614 613 -1
============================================
+ Hits 2595 2600 +5
+ Misses 1288 1287 -1
+ Partials 161 160 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kibana-reports/server/index.ts
Outdated
exposeToBrowser: { | ||
access: true, | ||
}, | ||
schema: configSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this file do besides defining KibanaReportsPluginConfigType
? it seems it's adding port and basepath config to the kibana.yml file? shouldn't be necessary since we are not reading from yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I forget to remove when I tried the plugin config approach. Will remove
) => { | ||
report.query_url = report.query_url.replace(basePath, ''); | ||
report.report_definition.report_params.core_params.base_url = report.report_definition.report_params.core_params.base_url.replace( | ||
basePath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is query_url/base_url the full url with hostname? e.g. localhost:5601/alh/app/...
would it replace alh
in localhost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query_url
doesn't contain hostname
This reverts commit 21aebcc.
Issue #, if available:
#98
This is the most reported issue so far. Users are not able to generate any report if they have customized Kibana sever setting(host, sever base path, port), or enable TLS.
Server config is set in kibana.yml
Description of changes:
localhost:5601
when building the complete urlserverInfo
(which containsport
,host
,protocol
), andserver.basePath
and pass them through route handler for validating the input url, compose complete url.ignoreHttpsError: true
to support TLS-enabled kibana server https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#puppeteerlaunchoptionsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.