This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Resolve KNN Lib Version Hard Coding Issues and Upgrades #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
changed the title
peterzhuamazon
force-pushed
the
opendistro-infra-issues-251-2
branch
from
2df7f9e
to
f64bcab
Compare
peterzhuamazon
changed the title
peterzhuamazon
force-pushed
the
opendistro-infra-issues-251-2
branch
from
f64bcab
to
b6f1405
Compare
camerski
approved these changes
Aug 26, 2020
weicongs-amazon
approved these changes
Aug 26, 2020
This was referenced Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/opendistro-for-elasticsearch/opendistro-infra/issues/251
Description of changes:
This is to fix the issues with KNN Lib Version Hard Coding and Upgrades
It also removed the long standing preinstall script for deb/rpm (which also has hard coding KNNLib versions) as we are not using this method anymore
Test Results:
https://github.com/opendistro-for-elasticsearch/opendistro-build/pull/359/checks?check_run_id=1033423398
It fails because of email credentials, not because of the tests here
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.