This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
update readme to fix #379 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @peterzhuamazon |
|
Hi @dmpe can you also remove https://github.com/opendistro-for-elasticsearch/opendistro-build/blame/a7a5fbf111483dcb86c14ad34497b96423d12879/helm/README.md#L519 This line is also related to the settings as it is deprecated now. |
|
Thanks, good catch. |
|
Hi @dmpe sorry to bother you again. I should do a global search earlier. Sorry about the inconvinience. Thanks. |
|
Well, I should have done that as well |
gaiksaya
approved these changes
Sep 11, 2020
peterzhuamazon
approved these changes
Sep 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#379
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.