This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add new cookie settings for security kibana plugins 2.0 framework when https is disabled #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n https is disabled
gaiksaya
approved these changes
Sep 23, 2020
camerski
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/opendistro-for-elasticsearch/opendistro-infra/issues/251
Description of changes:
This PR is to add new cookie settings for security kibana plugins 2.0 framework when https is disabled
The 2.0 framework is forcing 1 to 1 match between https and cookie settings
Our kibana is default to http, thus requires cookie to be insecure
Users can choose to enable https and disable this config
$ find . -name kibana.yml
./kibana/docker/build/kibana/config/kibana.yml
./kibana/linux_distributions/config/kibana.yml
Test Results:
Manually tested on a EC2 instance, no automatic test yet.
Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks.
https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.