Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update the Perftop Package with new naming Convention for ODFE #68

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

adityaj1107
Copy link
Contributor

@adityaj1107 adityaj1107 commented Jan 21, 2021

Issue #, if available:

Description of changes: Updated the naming Convention of the binaries for Linux and Mac with the latest naming convention for ODFE

Testing:

aditjind@3c22fbd31611 perftop % ./gradlew build -Dbuild.linux=true -Dbuild.macos=true

> Configure project :

> pkg@4.4.9
> Warning Cannot resolve 'path.resolve(process.cwd(), args.dashboard)'
  /Users/aditjind/sifi_gh/perftop/lib/bin.js
  Dynamic require may fail at run time, because the requested file
  is unknown at compilation time and not included into executable.
  Use a string literal as an argument for 'require', or leave it
  as is and specify the resolved file name in 'scripts' option.

BUILD SUCCESSFUL in 17s
14 actionable tasks: 9 executed, 5 up-to-date
aditjind@3c22fbd31611 perftop % ./build/opendistro-perf-top-macos --dashboard ClusterOverview 
aditjind@3c22fbd31611 perftop % 

In Progress, Will update the results.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adityaj1107 adityaj1107 marked this pull request as draft January 21, 2021 23:42
@adityaj1107 adityaj1107 marked this pull request as ready for review January 22, 2021 19:08
Copy link
Contributor

@ricardolstephen ricardolstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityaj1107 adityaj1107 merged commit 14953ff into master Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants