ROS1 updates and fixes for several nodes #281
Conversation
tsampazk
added
test sources
…ion heatmap with improved colors and legend
tsampazk
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
|
All nodes mentioned in the PR's description should now have consistent argparse interface in terms of naming and usage, as well as fixed delay to what is described in #275. Also some minor fixes are included. Note that in case of testing, semantic segmentation bisenet node depends on this change made in another PR (#269) and should be working when both PRs are merged. |
|
Added some last minute changes, including ROS pose estimation now using a more useful custom ROS message as per partner feedback, updates to the bridge methods for the new pose messages. As far as i can tell these are the only custom ROS messages used by the toolkit currently, i took the liberty of adding the new messages to ros_bridge. Edit: These changes should fully conclude the basic enhancements and changes for AUTH ROS1 nodes so i will completely stop updating the branch until this PR is reviewed. |
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Thanks @stefaniapedrazzi, i commited the suggested changes. |
* Updated, cleaned up and added argparse to ROS1 pose estimation node * Added additional information for pose estimation node documentation * Improved wording in pose estimation ros docs * Minor comment improvement * Fix typo * Updated, cleaned up and added argparse to ROS1 fall detection node * Added box id type conversion that caused error in object det2d centernet * Updated, cleaned up and added argparse to ROS1 object detection 2d centernet node * Updated, cleaned up and added argparse to ROS1 object detection 2d ssd node * Updated, cleaned up and added argparse to ROS1 object detection 2d yolov3 node * Minor typo fix * Updated, cleaned up and added argparse to ROS1 object detection 2d DETR node * Updated, cleaned up and added argparse to ROS1 face detection retinaface node * Updated, cleaned up and added argparse to ROS1 semantic segmentation bisenet node * Increased buffer size for fall detection and pose estimation to minimize delay * Updated, cleaned up and added argparse to ROS1 face recognition node * Fixed minor type conversion typo in bridge * Sem seg bisenet now outputs class ids heatmap and separate visualization heatmap with improved colors and legend * Added custom opendr pose and keypoint messages on ros_bridge * Modified opendr_bridge from/to ros pose to use new messages and doc update * ROS1 pose node now uses new custom pose ros message * Enhanced pose __str__ method to return pose id and confidence * Update human_model_generation_client.py * Added missing space to pose out_string Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Fixed indentation on CMakeLists.txt Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> Co-authored-by: charsyme <63857415+charsyme@users.noreply.github.com> Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
This PR fixes or partially fixes #209 and #275, consistency updates, node arguments, documentation enhancements, and fixes for the following ROS1 nodes:
Edit: This PR should also fix
(will be re-checked)✅ the integer type issue (with commits c7df07b and 4c680cc) on the bridge method being used by ssd, yolov3, centernet object detection 2d nodes.