Ros1 fixes for 3D Detection and 2D/3D tracking #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliiliiliili
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
iliiliiliili
added
test sources
23 tasks
tsampazk
requested changes
Sep 29, 2022
There was a problem hiding this comment.
Thank you for the fixes on the nodes! I have left several comments below.
Most are minor things apart from the main issue that the nodes are missing the initialization that was there before as well as the listen methods. This is a point of difference between the ROS1 and ROS2 nodes that might have caused the confusion.
There are some updates needed in places where there are no changes on this PR so i couldn't directly comment on the lines, and consequently i added some comments with lists of changes regarding unchanged lines. I tried to make it as clear as possible, i hope they make sense.
projects/opendr_ws/src/perception/scripts/object_tracking_3d_ab3dmot.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_3d_ab3dmot.py
Outdated
Show resolved
Hide resolved
tsampazk
reviewed
Sep 30, 2022
projects/opendr_ws/src/perception/scripts/point_cloud_dataset.py
Outdated
Show resolved
Hide resolved
tsampazk
reviewed
Sep 30, 2022
tsampazk
reviewed
Sep 30, 2022
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
ad-daniel
requested changes
Oct 25, 2022
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_detection_3d_voxel.py
Outdated
Show resolved
Hide resolved
|
Thanks for the changes so far @iliiliiliili, when you feel that all the comments made in the reviews are resolved feel free to re-request a review. |
tsampazk
requested changes
Nov 11, 2022
There was a problem hiding this comment.
Thanks @iliiliiliili for the fixes so far, there are some stuff we missed the first time around.
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_detection_3d_voxel.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_3d_ab3dmot.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_3d_ab3dmot.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_3d_ab3dmot.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
tsampazk
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks @iliiliiliili, the nodes look great, apart from some very minor comments.
projects/opendr_ws/src/perception/scripts/object_tracking_2d_deep_sort.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_2d_fair_mot.py
Outdated
Show resolved
Hide resolved
ad-daniel
approved these changes
Nov 25, 2022
tsampazk
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Thanks @ad-daniel and @iliiliiliili. Note that the readme is updated and overhauled in #316 for all nodes.
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Fix ros1 3d detection * Fix ros1 tracking 3d node * Fix ros1 tracking 2d fairmot node * Fix ros1 tracking 2d deep sort node * Fix ros1 point cloud dataset node * Fix ros1 image dataset node * Fix style errors * Fix point cloud dataset init * Fix image dataset init node * Fix fair mot init * Fix image format rgb8 to bgr8 * Fix 3d detection init node * Fix re-download of the dataset * Fix fairmot conditional computing and typing * Fix deepsort init node * Fix ab3dmot init node * Add point cloud dataset anonymous node * Fix typo * Fix phrasing * Remove extra print * Apply suggestions from code review Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Fix sources * Fix names * Add topic comments * Move fairmot to rgb-based * Fix deep sort direction incompatibility * Fix bounding box frame reference * Exlude opendr_ws devel from source check * Optimize deep sort topic computations * Fixes * More fixes Co-authored-by: Illia Oleksiienko <io@ece.u.dk> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
object_detection_3d_voxel_node.py,point_cloud_dataset_node.pyobject_tracking_3d_ab3dmot_node.pyobject_tracking_2d_fair_mot_node.py,object_tracking_2d_deep_sort_node.py,image_dataset_node.py