High Resolution Pose Estimation new tool #356

mthodoris · 2022-11-28T11:29:47Z

High-Resolution Pose Estimation tool

Inference demo on 1080p image
Evaluation demo
Benchmarking demo
Corrections on README files and documentation

ad-daniel

Thank you, I've left a few comments. Additionally, the current PR is missing:

a CHANGELOG entry should be added
the demo folder should be placed inside projects/python/perception/pose_estimation (and lightweight_open_pose should be moved there too).
the documentation page for this tool should be referred in the index.md file
the demo should also be referred in the index.md file (please also fix the lightweight open pose link there since it has been moved)

docs/reference/high_resolution_pose_estimation.md

src/opendr/perception/pose_estimation/hr_pose_estimation/HighResolutionLearner.py

ad-daniel · 2022-12-12T07:51:25Z

Also the pose_estimation test seems to have been canceled for taking 6+ hours. Can you check if it's a random failure or if there is indeed an issue with the changes done in this PR? (you can rerun the test 2-3 times after you've done the the fixes)

projects/python/perception/high_resolution_pose_estimation/README.md

src/opendr/perception/pose_estimation/hr_pose_estimation/HighResolutionLearner.py

src/opendr/perception/pose_estimation/hr_pose_estimation/algorithm/datasets/transformations.py

src/opendr/perception/pose_estimation/hr_pose_estimation/algorithm/datasets/coco.py

src/opendr/perception/pose_estimation/hr_pose_estimation/algorithm/models/with_mobilenet.py

src/opendr/perception/pose_estimation/hr_pose_estimation/algorithm/modules/conv.py

src/opendr/perception/pose_estimation/hr_pose_estimation/algorithm/scripts/make_val_subset.py

tsampazk · 2022-12-12T09:19:07Z

Also the pose_estimation test seems to have been canceled for taking 6+ hours. Can you check if it's a random failure or if there is indeed an issue with the changes done in this PR? (you can rerun the test 2-3 times after you've done the the fixes)

Hey @ad-daniel, from what i can tell, it seems to be an issue with this PR, as the regular pose estimation tests in other PRs are completed in 10-15 mins. I triggered a rerun to check again.

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

tsampazk

Thanks @mthodoris! I added several comments apart from what Nikos and Daniel mentioned.

docs/reference/high_resolution_pose_estimation.md

src/opendr/perception/pose_estimation/hr_pose_estimation/HighResolutionLearner.py

tests/test_license.py

ad-daniel · 2022-12-12T12:35:01Z

Something might indeed be wrong, the pose estimation test has been running for 1h30 after the last retry. I've canceled the job

passalis

I have simplified a bit the main learner class to further reduce code duplication. Please check that everything is still ok. I also think that we should have docstrings similar to the rest of the tools.

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py

into hr_pose_estimation

edited hardcoded values, removed unnecessary values from learner, added docstrings in functions edited the readme file after the changes

docs/reference/high-resolution-pose-estimation.md

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

passalis

Thank you! I am ok with the changes.

tsampazk

Thanks Thodoris and Nikos for the fixes so far. Some final comments, most are minor!

docs/reference/high-resolution-pose-estimation.md

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

tsampazk

Thank you, changes LGTM!

ad-daniel

Thank you

* High Resolution Pose Estimation new tool * changes on path for 1080pi image input * adding height1 height2 as params to learner * typos * fixed tests * edit Readme files, edit files(PEP8 changes) to pass tests * fix formatting * Apply suggestions from code review Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> * Minor fix in comments of original pose estimation node * HR pose estimation ros1 node * Apply suggestions from code review Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * suggestions from review (edit functions, code duplication,typos,etc) * suggestions from review (edit functions, code duplication,typos,etc) * edit some paths * changes for test errors * apply suggestions from review * Apply suggestions from code review type casting issue on height variables str() to int() Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> * Missing stuff * add a CHANGELOG entry, reference the demo and documentation in index.md * Simplified HR pose estimation * pep8 fixes * apply review suggestions edited hardcoded values, removed unnecessary values from learner, added docstrings in functions edited the readme file after the changes * Update docs/reference/high-resolution-pose-estimation.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * review fixes * typos Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Nikolaos <passalis@csd.auth.gr>

High Resolution Pose Estimation new tool

46aabce

tsampazk added test sources Run style checks test tools Test the toolkit methods labels Nov 28, 2022

tsampazk assigned mthodoris Nov 28, 2022

mthodoris and others added 7 commits December 1, 2022 14:47

changes on path for 1080pi image input

3d2612f

adding height1 height2 as params to learner

d3756c2

typos

9a8fe2b

fixed tests

a0d90e7

edit Readme files, edit files(PEP8 changes) to pass tests

e45ba3a

Merge branch 'develop' into hr_pose_estimation

0ca25e1

Merge branch 'develop' into hr_pose_estimation

37aeb65

mthodoris marked this pull request as ready for review December 8, 2022 07:44

mthodoris requested review from passalis, omichel, ad-daniel and stefaniapedrazzi as code owners December 8, 2022 07:44

tsampazk and others added 3 commits December 8, 2022 13:46

Merge branch 'develop' into hr_pose_estimation

95ede8d

Merge branch 'develop' into hr_pose_estimation

49aa849

fix formatting

0081557

ad-daniel requested changes Dec 11, 2022

View reviewed changes

passalis requested changes Dec 12, 2022

View reviewed changes

mthodoris and others added 2 commits December 12, 2022 11:56

Apply suggestions from code review

6ba580c

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

Merge branch 'develop' into hr_pose_estimation

b012f18

tsampazk requested changes Dec 12, 2022

View reviewed changes

tsampazk added 2 commits December 12, 2022 17:14

Minor fix in comments of original pose estimation node

8d906b3

HR pose estimation ros1 node

5334c7e

tsampazk mentioned this pull request Dec 12, 2022

ROS2 workspace and example nodes #256

Merged

24 tasks

passalis reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

passalis reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

passalis reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

passalis reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

mthodoris and others added 4 commits December 21, 2022 11:19

Merge branch 'hr_pose_estimation' of https://github.com/opendr-eu/opendr

3bf439c

into hr_pose_estimation

Merge branch 'develop' into hr_pose_estimation

4ba8ae3

Merge branch 'hr_pose_estimation' of https://github.com/opendr-eu/opendr

4234552

into hr_pose_estimation

apply review suggestions

4a6c7d2

edited hardcoded values, removed unnecessary values from learner, added docstrings in functions edited the readme file after the changes

mthodoris requested a review from passalis December 21, 2022 11:30

passalis reviewed Dec 21, 2022

View reviewed changes

docs/reference/high-resolution-pose-estimation.md Outdated Show resolved Hide resolved

Update docs/reference/high-resolution-pose-estimation.md

664d0bb

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

mthodoris requested a review from passalis December 21, 2022 12:14

passalis previously approved these changes Dec 21, 2022

View reviewed changes

tsampazk requested changes Dec 21, 2022

View reviewed changes

tsampazk reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

tsampazk reviewed Dec 21, 2022

View reviewed changes

src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py Outdated Show resolved Hide resolved

Apply suggestions from code review

82313ba

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

mthodoris dismissed passalis’s stale review via 82313ba December 21, 2022 13:58

mthodoris and others added 2 commits December 21, 2022 16:01

Apply suggestions from code review

bcf222b

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

review fixes

d6853ad

tsampazk requested review from passalis and tsampazk December 21, 2022 14:22

typos

18dff24

tsampazk approved these changes Dec 21, 2022

View reviewed changes

Merge branch 'develop' into hr_pose_estimation

27a614d

ad-daniel approved these changes Dec 21, 2022

View reviewed changes

tsampazk merged commit bedccdd into develop Dec 21, 2022

tsampazk deleted the hr_pose_estimation branch December 21, 2022 16:46

tsampazk mentioned this pull request Jan 5, 2023

Lightweight OpenPose tool fixes and improvements #392

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

High Resolution Pose Estimation new tool #356

High Resolution Pose Estimation new tool #356

mthodoris commented Nov 28, 2022 •

edited

Loading

ad-daniel left a comment

ad-daniel commented Dec 12, 2022

tsampazk commented Dec 12, 2022

tsampazk left a comment

ad-daniel commented Dec 12, 2022

passalis left a comment •

edited

Loading

passalis left a comment

tsampazk left a comment

tsampazk left a comment

ad-daniel left a comment

High Resolution Pose Estimation new tool #356

High Resolution Pose Estimation new tool #356

Conversation

mthodoris commented Nov 28, 2022 • edited Loading

ad-daniel left a comment

Choose a reason for hiding this comment

ad-daniel commented Dec 12, 2022

tsampazk commented Dec 12, 2022

tsampazk left a comment

Choose a reason for hiding this comment

ad-daniel commented Dec 12, 2022

passalis left a comment • edited Loading

Choose a reason for hiding this comment

passalis left a comment

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

ad-daniel left a comment

Choose a reason for hiding this comment

mthodoris commented Nov 28, 2022 •

edited

Loading

passalis left a comment •

edited

Loading