Ambiguity measure #361
Merged
Ambiguity measure #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelledouwe
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
ad-daniel
added
test sources
…ambiguity_measure
ad-daniel
requested changes
Dec 7, 2022
There was a problem hiding this comment.
Thank you, being an utility I think what you did is sufficient. I have however a couple of comments:
- you have created a test (and locally it worked for me) but currently the tool is not being tested in the CI (you need to add it to the .yml files, both master and develop)
- I believe the the intent is for this tool to be distributed separately (like we do for the hyperparameter tuner), in which case you also need to add it to packages.txt so that one is created for it
- add a changelog entry
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Hi Daniel, thanks for the review! I believe the test is currently already tested in the CI. At least, it appears in the actions on this branch under the util tests. I added the entry to the package list and the changelog. |
ad-daniel
previously approved these changes
Dec 8, 2022
tsampazk
previously approved these changes
Dec 8, 2022
ad-daniel
approved these changes
Dec 8, 2022
tsampazk
approved these changes
Dec 8, 2022
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Create docs, tests and tutorial for ambiguity measure * update tutorial * Add link to colab tutorial * update style * add ambiguity measure * Apply suggestions from code review Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * add ambiguity measure to package list and changelog * Apply suggestions from code review Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the AmbiguityMeasure tool for human robot interaction. It is related to one of our recent publications. We also created a colab.