Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in GEM ROS2 node #420

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix bug in GEM ROS2 node #420

merged 1 commit into from
Mar 20, 2023

Conversation

jelledouwe
Copy link
Collaborator

Cannot set qos_profile for message filter subscribers, therefore removing this argument.
Fixes #415

@jelledouwe jelledouwe changed the title remove qos_profile in message_filters subscribers Fix bug in GEM ROS2 node Mar 13, 2023
@ad-daniel ad-daniel added the test sources Run style checks label Mar 13, 2023
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tsampazk
Copy link
Collaborator

Should this be merged into master indeed @ad-daniel ?

@ad-daniel
Copy link
Collaborator

as it's a bugfix yes

@ad-daniel ad-daniel merged commit f2b5b05 into master Mar 20, 2023
@ad-daniel ad-daniel deleted the gem-patch branch March 20, 2023 08:54
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS2 Node for Object Detection 2D Gem gives Error
3 participants