Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update citation of Seq2Seq-NMS #427

Merged
merged 12 commits into from
May 17, 2023
Merged

Update citation of Seq2Seq-NMS #427

merged 12 commits into from
May 17, 2023

Conversation

charsyme
Copy link
Collaborator

@charsyme charsyme commented Apr 7, 2023 •
edited
Loading

This PR updates the citation of Seq2Seq-NMS. The methods was previously cited using the preprint version.

@charsyme charsyme added the documentation Improvements or additions to documentation label Apr 7, 2023
@stefaniapedrazzi
Copy link
Collaborator

Could you please update this PR title and description and add some more information?

Please also just write a message here when this PR is ready for the review.

@charsyme charsyme changed the title Update README.md Update citation of Seq2Seq-NMS May 3, 2023
@charsyme
Copy link
Collaborator Author

charsyme commented May 3, 2023

This PR is ready for the review

stefaniapedrazzi
stefaniapedrazzi reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the reference link?
Even if you removed the link to the documentation, it seems to be better to have a link in the text that points to the reference instead of just [1] text.

@charsyme
Copy link
Collaborator Author

charsyme commented May 8, 2023 •
edited
Loading

@stefaniapedrazzi I made the necessary changes, I think it's ok now.

stefaniapedrazzi
stefaniapedrazzi approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charsyme charsyme added test sources Run style checks test tools Test the toolkit methods labels May 8, 2023
@stefaniapedrazzi stefaniapedrazzi removed the test tools Test the toolkit methods label May 9, 2023
@charsyme charsyme merged commit da36893 into master May 17, 2023
@charsyme charsyme deleted the nms_changes_in_readme branch May 17, 2023 10:00
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@charsyme @stefaniapedrazzi
Update citation of Seq2Seq-NMS (opendr-eu#427)
98dc5bc 
* Update README.md

* Update README.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update README.md

* Update README.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update README.md

---------

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passalis passalis passalis approved these changes

@stefaniapedrazzi stefaniapedrazzi stefaniapedrazzi approved these changes

@omichel omichel Awaiting requested review from omichel omichel is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation test sources Run style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charsyme @stefaniapedrazzi @passalis